fix(appset): do not trigger reconciliation on appsets not part of allowed namespaces when updating a cluster secret (cherry-pick #25622 for 3.2) #25911
+44
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owed namespaces when updating a cluster secret (#25622) Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
14 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-3.2 #25911 +/- ##
===============================================
+ Coverage 62.06% 62.10% +0.04%
===============================================
Files 351 351
Lines 49041 49044 +3
===============================================
+ Hits 30438 30460 +22
+ Misses 15673 15656 -17
+ Partials 2930 2928 -2 ☔ View full report in Codecov by Sentry. |
blakepettersson
approved these changes
Jan 9, 2026
blakepettersson
approved these changes
Jan 9, 2026
renovate bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Jan 19, 2026
##### [\`v3.2.5\`](https://github.com/argoproj/argo-cd/releases/tag/v3.2.5) ##### Quick Start ##### Non-HA: ```shell kubectl create namespace argocd kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v3.2.5/manifests/install.yaml ``` ##### HA: ```shell kubectl create namespace argocd kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v3.2.5/manifests/ha/install.yaml ``` ##### Release Signatures and Provenance All Argo CD container images are signed by cosign. A Provenance is generated for container images and CLI binaries which meet the SLSA Level 3 specifications. See the [documentation](https://argo-cd.readthedocs.io/en/stable/operator-manual/signed-release-assets) on how to verify. ##### Release Notes Blog Post For a detailed breakdown of the key changes and improvements in this release, check out the [official blog post](https://blog.argoproj.io/argo-cd-v3-0-release-candidate-a0b933f4e58f) ##### Upgrading If upgrading from a different minor version, be sure to read the [upgrading](https://argo-cd.readthedocs.io/en/stable/operator-manual/upgrading/overview/) documentation. ##### Changelog ##### Features - [`fafbd44`](argoproj/argo-cd@fafbd44): feat: Cherry-pick to 3.2 update notifications engine to v0.5.1 0.20251223091026 [`8c0c96d`](argoproj/argo-cd@8c0c96d8d530) ([#25930](argoproj/argo-cd#25930)) ([@reggie-k](https://github.com/reggie-k)) ##### Bug fixes - [`d7d9674`](argoproj/argo-cd@d7d9674): fix(appset): do not trigger reconciliation on appsets not part of allowed namespaces when updating a cluster secret (cherry-pick [#25622](argoproj/argo-cd#25622) for 3.2) ([#25911](argoproj/argo-cd#25911)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot]) - [`e6f5403`](argoproj/argo-cd@e6f5403): fix: Only show please update resource specification message when spec… (cherry-pick [#25066](argoproj/argo-cd#25066) for 3.2) ([#25895](argoproj/argo-cd#25895)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot]) ##### Documentation - [`e9d03a6`](argoproj/argo-cd@e9d03a6): docs: Run make codegen for notifications engine changes ([#25958](argoproj/argo-cd#25958)) ([@reggie-k](https://github.com/reggie-k)) - [`b67eb40`](argoproj/argo-cd@b67eb40): docs: link to source hydrator (cherry-pick [#25813](argoproj/argo-cd#25813) for 3.2) ([#25814](argoproj/argo-cd#25814)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot]) ##### Dependency updates - [`8a0633b`](argoproj/argo-cd@8a0633b): chore(deps): bump go to 1.25.5 (cherry-pick) ([#25805](argoproj/argo-cd#25805)) ([@nitishfy](https://github.com/nitishfy)) ##### Other work - [`b414696`](argoproj/argo-cd@b414696): chore(cherry-pick-3.2): bump `expr` to `v1.17.7` ([#25889](argoproj/argo-cd#25889)) ([@nitishfy](https://github.com/nitishfy)) - [`51c6375`](argoproj/argo-cd@51c6375): ci: test against k8s 1.34.2 (cherry-pick [#25856](argoproj/argo-cd#25856) for 3.2) ([#25859](argoproj/argo-cd#25859)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot]) **Full Changelog**: <argoproj/argo-cd@v3.2.3...v3.2.5> <a href="https://argoproj.github.io/cd/"><img src="https://raw.githubusercontent.com/argoproj/argo-site/master/content/pages/cd/gitops-cd.png" width="25%" ></a> --- ##### [\`v3.2.4\`](https://github.com/argoproj/argo-cd/releases/tag/v3.2.4) ##### Important notice about this release This release is invalid, please use the v3.2.5 instead.
renovate bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Jan 19, 2026
##### [\`v3.2.5\`](https://github.com/argoproj/argo-cd/releases/tag/v3.2.5) ##### Quick Start ##### Non-HA: ```shell kubectl create namespace argocd kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v3.2.5/manifests/install.yaml ``` ##### HA: ```shell kubectl create namespace argocd kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v3.2.5/manifests/ha/install.yaml ``` ##### Release Signatures and Provenance All Argo CD container images are signed by cosign. A Provenance is generated for container images and CLI binaries which meet the SLSA Level 3 specifications. See the [documentation](https://argo-cd.readthedocs.io/en/stable/operator-manual/signed-release-assets) on how to verify. ##### Release Notes Blog Post For a detailed breakdown of the key changes and improvements in this release, check out the [official blog post](https://blog.argoproj.io/argo-cd-v3-0-release-candidate-a0b933f4e58f) ##### Upgrading If upgrading from a different minor version, be sure to read the [upgrading](https://argo-cd.readthedocs.io/en/stable/operator-manual/upgrading/overview/) documentation. ##### Changelog ##### Features - [`fafbd44`](argoproj/argo-cd@fafbd44): feat: Cherry-pick to 3.2 update notifications engine to v0.5.1 0.20251223091026 [`8c0c96d`](argoproj/argo-cd@8c0c96d8d530) ([#25930](argoproj/argo-cd#25930)) ([@reggie-k](https://github.com/reggie-k)) ##### Bug fixes - [`d7d9674`](argoproj/argo-cd@d7d9674): fix(appset): do not trigger reconciliation on appsets not part of allowed namespaces when updating a cluster secret (cherry-pick [#25622](argoproj/argo-cd#25622) for 3.2) ([#25911](argoproj/argo-cd#25911)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot]) - [`e6f5403`](argoproj/argo-cd@e6f5403): fix: Only show please update resource specification message when spec… (cherry-pick [#25066](argoproj/argo-cd#25066) for 3.2) ([#25895](argoproj/argo-cd#25895)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot]) ##### Documentation - [`e9d03a6`](argoproj/argo-cd@e9d03a6): docs: Run make codegen for notifications engine changes ([#25958](argoproj/argo-cd#25958)) ([@reggie-k](https://github.com/reggie-k)) - [`b67eb40`](argoproj/argo-cd@b67eb40): docs: link to source hydrator (cherry-pick [#25813](argoproj/argo-cd#25813) for 3.2) ([#25814](argoproj/argo-cd#25814)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot]) ##### Dependency updates - [`8a0633b`](argoproj/argo-cd@8a0633b): chore(deps): bump go to 1.25.5 (cherry-pick) ([#25805](argoproj/argo-cd#25805)) ([@nitishfy](https://github.com/nitishfy)) ##### Other work - [`b414696`](argoproj/argo-cd@b414696): chore(cherry-pick-3.2): bump `expr` to `v1.17.7` ([#25889](argoproj/argo-cd#25889)) ([@nitishfy](https://github.com/nitishfy)) - [`51c6375`](argoproj/argo-cd@51c6375): ci: test against k8s 1.34.2 (cherry-pick [#25856](argoproj/argo-cd#25856) for 3.2) ([#25859](argoproj/argo-cd#25859)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot]) **Full Changelog**: <argoproj/argo-cd@v3.2.3...v3.2.5> <a href="https://argoproj.github.io/cd/"><img src="https://raw.githubusercontent.com/argoproj/argo-site/master/content/pages/cd/gitops-cd.png" width="25%" ></a> --- ##### [\`v3.2.4\`](https://github.com/argoproj/argo-cd/releases/tag/v3.2.4) ##### Important notice about this release This release is invalid, please use the v3.2.5 instead.
renovate bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Jan 19, 2026
##### [\`v3.2.5\`](https://github.com/argoproj/argo-cd/releases/tag/v3.2.5) ##### Quick Start ##### Non-HA: ```shell kubectl create namespace argocd kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v3.2.5/manifests/install.yaml ``` ##### HA: ```shell kubectl create namespace argocd kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v3.2.5/manifests/ha/install.yaml ``` ##### Release Signatures and Provenance All Argo CD container images are signed by cosign. A Provenance is generated for container images and CLI binaries which meet the SLSA Level 3 specifications. See the [documentation](https://argo-cd.readthedocs.io/en/stable/operator-manual/signed-release-assets) on how to verify. ##### Release Notes Blog Post For a detailed breakdown of the key changes and improvements in this release, check out the [official blog post](https://blog.argoproj.io/argo-cd-v3-0-release-candidate-a0b933f4e58f) ##### Upgrading If upgrading from a different minor version, be sure to read the [upgrading](https://argo-cd.readthedocs.io/en/stable/operator-manual/upgrading/overview/) documentation. ##### Changelog ##### Features - [`fafbd44`](argoproj/argo-cd@fafbd44): feat: Cherry-pick to 3.2 update notifications engine to v0.5.1 0.20251223091026 [`8c0c96d`](argoproj/argo-cd@8c0c96d8d530) ([#25930](argoproj/argo-cd#25930)) ([@reggie-k](https://github.com/reggie-k)) ##### Bug fixes - [`d7d9674`](argoproj/argo-cd@d7d9674): fix(appset): do not trigger reconciliation on appsets not part of allowed namespaces when updating a cluster secret (cherry-pick [#25622](argoproj/argo-cd#25622) for 3.2) ([#25911](argoproj/argo-cd#25911)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot]) - [`e6f5403`](argoproj/argo-cd@e6f5403): fix: Only show please update resource specification message when spec… (cherry-pick [#25066](argoproj/argo-cd#25066) for 3.2) ([#25895](argoproj/argo-cd#25895)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot]) ##### Documentation - [`e9d03a6`](argoproj/argo-cd@e9d03a6): docs: Run make codegen for notifications engine changes ([#25958](argoproj/argo-cd#25958)) ([@reggie-k](https://github.com/reggie-k)) - [`b67eb40`](argoproj/argo-cd@b67eb40): docs: link to source hydrator (cherry-pick [#25813](argoproj/argo-cd#25813) for 3.2) ([#25814](argoproj/argo-cd#25814)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot]) ##### Dependency updates - [`8a0633b`](argoproj/argo-cd@8a0633b): chore(deps): bump go to 1.25.5 (cherry-pick) ([#25805](argoproj/argo-cd#25805)) ([@nitishfy](https://github.com/nitishfy)) ##### Other work - [`b414696`](argoproj/argo-cd@b414696): chore(cherry-pick-3.2): bump `expr` to `v1.17.7` ([#25889](argoproj/argo-cd#25889)) ([@nitishfy](https://github.com/nitishfy)) - [`51c6375`](argoproj/argo-cd@51c6375): ci: test against k8s 1.34.2 (cherry-pick [#25856](argoproj/argo-cd#25856) for 3.2) ([#25859](argoproj/argo-cd#25859)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot]) **Full Changelog**: <argoproj/argo-cd@v3.2.3...v3.2.5> <a href="https://argoproj.github.io/cd/"><img src="https://raw.githubusercontent.com/argoproj/argo-site/master/content/pages/cd/gitops-cd.png" width="25%" ></a> --- ##### [\`v3.2.4\`](https://github.com/argoproj/argo-cd/releases/tag/v3.2.4) ##### Important notice about this release This release is invalid, please use the v3.2.5 instead.
renovate bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Jan 19, 2026
##### [\`v3.2.5\`](https://github.com/argoproj/argo-cd/releases/tag/v3.2.5) ##### Quick Start ##### Non-HA: ```shell kubectl create namespace argocd kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v3.2.5/manifests/install.yaml ``` ##### HA: ```shell kubectl create namespace argocd kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/v3.2.5/manifests/ha/install.yaml ``` ##### Release Signatures and Provenance All Argo CD container images are signed by cosign. A Provenance is generated for container images and CLI binaries which meet the SLSA Level 3 specifications. See the [documentation](https://argo-cd.readthedocs.io/en/stable/operator-manual/signed-release-assets) on how to verify. ##### Release Notes Blog Post For a detailed breakdown of the key changes and improvements in this release, check out the [official blog post](https://blog.argoproj.io/argo-cd-v3-0-release-candidate-a0b933f4e58f) ##### Upgrading If upgrading from a different minor version, be sure to read the [upgrading](https://argo-cd.readthedocs.io/en/stable/operator-manual/upgrading/overview/) documentation. ##### Changelog ##### Features - [`fafbd44`](argoproj/argo-cd@fafbd44): feat: Cherry-pick to 3.2 update notifications engine to v0.5.1 0.20251223091026 [`8c0c96d`](argoproj/argo-cd@8c0c96d8d530) ([#25930](argoproj/argo-cd#25930)) ([@reggie-k](https://github.com/reggie-k)) ##### Bug fixes - [`d7d9674`](argoproj/argo-cd@d7d9674): fix(appset): do not trigger reconciliation on appsets not part of allowed namespaces when updating a cluster secret (cherry-pick [#25622](argoproj/argo-cd#25622) for 3.2) ([#25911](argoproj/argo-cd#25911)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot]) - [`e6f5403`](argoproj/argo-cd@e6f5403): fix: Only show please update resource specification message when spec… (cherry-pick [#25066](argoproj/argo-cd#25066) for 3.2) ([#25895](argoproj/argo-cd#25895)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot]) ##### Documentation - [`e9d03a6`](argoproj/argo-cd@e9d03a6): docs: Run make codegen for notifications engine changes ([#25958](argoproj/argo-cd#25958)) ([@reggie-k](https://github.com/reggie-k)) - [`b67eb40`](argoproj/argo-cd@b67eb40): docs: link to source hydrator (cherry-pick [#25813](argoproj/argo-cd#25813) for 3.2) ([#25814](argoproj/argo-cd#25814)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot]) ##### Dependency updates - [`8a0633b`](argoproj/argo-cd@8a0633b): chore(deps): bump go to 1.25.5 (cherry-pick) ([#25805](argoproj/argo-cd#25805)) ([@nitishfy](https://github.com/nitishfy)) ##### Other work - [`b414696`](argoproj/argo-cd@b414696): chore(cherry-pick-3.2): bump `expr` to `v1.17.7` ([#25889](argoproj/argo-cd#25889)) ([@nitishfy](https://github.com/nitishfy)) - [`51c6375`](argoproj/argo-cd@51c6375): ci: test against k8s 1.34.2 (cherry-pick [#25856](argoproj/argo-cd#25856) for 3.2) ([#25859](argoproj/argo-cd#25859)) ([@argo-cd-cherry-pick-bot](https://github.com/argo-cd-cherry-pick-bot)\[bot]) **Full Changelog**: <argoproj/argo-cd@v3.2.3...v3.2.5> <a href="https://argoproj.github.io/cd/"><img src="https://raw.githubusercontent.com/argoproj/argo-site/master/content/pages/cd/gitops-cd.png" width="25%" ></a> --- ##### [\`v3.2.4\`](https://github.com/argoproj/argo-cd/releases/tag/v3.2.4) ##### Important notice about this release This release is invalid, please use the v3.2.5 instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix(appset): do not trigger reconciliation on appsets not part of allowed namespaces when updating a cluster secret (#25622)
Signed-off-by: OpenGuidou guillaume.doussin@gmail.com